Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

Re: Proposal for new workflow, incorporating "Optimistic Merging"

by
Elico Corp, Eric Caudal
- 08/06/2016 10:41:54
This is what we would intend to do
--
Eric Caudal [Founder and CEO]
Skype: elico.corp. Phone: + 86 186 2136 1670 (Cell), + 86 21 6211 8017/27/37 (Office)
Elico Shanghai (Hong Kong/Shenzhen/Singapore) Odoo Gold Partner, best Odoo Partner 2014 for APAC
On 06/08/2016 04:38 PM, Leonardo Pistone wrote:
<blockquote cite="mid:CAATsmLEsjkCDbPbnudCkTBNHTDMQFJ00skGqTMfUXHbyKG0GNQ@mail.gmail.com" type="cite">
One remark: I think an optimistic merge should be blocked by a red
build (and almost nothing else). Otherwise the whole branch becomes
red and CI is worthless, and a huge work needs to be done at the end.
In other words, I think the automated part of the review must stay in
the optimistic version.

Reference