Contributors mailing list archives

contributors@odoo-community.org

Re: Proposal for new workflow, incorporating "Optimistic Merging"

by
Vauxoo, Nhomar Hernández
- 07/06/2016 17:04:15

On Tue, Jun 7, 2016 at 11:53 AM, robert rottermann <robert@redcor.ch> wrote:

I believe we should try to find a way along this lines.
The actual situation is plain bad I think.
It actively discourages contributers and blocks good stuff waiting to be evaluated
EVERYONE of us should be able to check the code.

But EVERYONE needs a handle to judge what code is good and stable.


Hi Robert.

Thanks for the comment.

Just FYI, now we (the commiters) only wait for 2 +1 (it is the rule) and EVERYONE can give a +1 in a PR, for responsability we ask make a real review but honestly that's based on trust some people say "+1 functional" or "+1 technical but I think x,y,z"....

We are more like commit channels (like the high level team side by side Linus Torvalds) even he say that honestly when he mention "I trust in no more than 10 persons, if they tested I merge" well that's more or less the same here.

You can easily Pick any PR (OCa member or not) just test it (functionally in runbot no technical skill needed) and give your +1.

Then the fact that EVERYONE can judge is a matter of fact today, you +1 is respected and if you considered you tested partially something, just mention that than another person can give a +1 to the part you did not test.

I hope see you in github I am sure you will give good visual of what you use, at least to giv feedback.

I think we must prepara a video with this working becuse the impression we are giving today is that we the mergers has the power of Block which is not totally true, we have the responsability of merge which is different.

Why no more Open, it means 100% have merge power?

We had that in this repository years ago: https://code.launchpad.net/openerp-extra

And the results were really BAD, the process we have today was to enable a minimal quality check because nobody was responsible at that time.

Now you can know who is in chage of what, and you can (by yourself) simply give a ping if something is blocked and give you own +1 (even functionally).

I love the process we have now, even If I accept it can be improved (and it must) what we can not say is that "It is BAD" and you can I repeat, give a valuable +1 if you test something (in runbot , no technical knowledges needed).

Thanks again, I hope it clarify a little the process we have now.




--
Nhomar Hernandez
CEO Vauxoo.
Twitter: @nhomar
Odoo Gold Partner
Skype: nhomar00 (Envia mail previo no lo superviso siempre).
Móvil Venezuela:
+58 4144110269
Móvil México:
+52 1 4773933942