Contributors mailing list archives

contributors@odoo-community.org

Re: Proposal for new workflow, incorporating "Optimistic Merging"

by
Therp, Holger Brunn
- 06/06/2016 16:39:26
> The "Optimistic Merging" strategy that can make that possible:
> Instead of requesting the contributor to have perfect code,
> contributions are quickly merged so that others can improve them ("crowd
> patching"). This provides a more satisfying experience to contributors,
> and provides some "low hanging fruit" for newcomers, such as simple code
> style fixes.

I'm not in favor of implementing this for the time being. In all projects I'm 
involved currently, the problem is not lack of contributions, but lack of 
reviewers. And most of this proposal actually increases work load for existing 
reviewers.

If anything I'd like to make it harder to get things merged, such as changing 
the coverage sentence [1] from a *should* to a *must* and similar.

Also a clearer procedure when a PR can be closed unmerged and a way stricter 
time frame for that (