Contributors mailing list archives

contributors@odoo-community.org

Re: Should we use the new GitHub reactions?

by Yajo <yajo.sk8@gmail.com> - 16/03/2016 08:12:36

2016-03-15 20:38 GMT+01:00 Salton Massally <smassally@idtlabs.sl>:
I think he means a dashboard via which you can see only PRs with above 3+


I don't think such thing exists.


2016-03-11 10:13 GMT+01:00 Yajo <yajo.sk8@gmail.com>:
However I don't know how/if GH notifies the participants about reactions, so maybe you still prefer the old add a comment behavior for approvals... In such case, it could be also specified in the guidelines to avoid mistakes by casual reviewers.

After trying, you don't get notifications, so IMHO it's better to add a comment, or reviewers may have to review the PR all the time to know if it should be merged.

Right now I have 43 open PR, I cannot review all of them to see if there are new +1s, and I don't only review mines...