Contributors mailing list archives

contributors@odoo-community.org

Re: OCA Addons Packaging next step

by
Acsone SA, Stéphane Bidoul
- 14/03/2016 11:36:06
Hello Daniel,

Thanks for looking in to this. My comments inline below.

On Fri, Mar 11, 2016 at 7:23 PM, Daniel Reis <dgreis@sapo.pt> wrote:

a) I would prefer to have a ".setup" directory name instead of "setup".  Is this viable?

It would work I think. But I prefer setup because
* even if it is autogenerated most of the time, sometimes the setup.py can and will be adapted manually to cover special cases, or express explicit version dependencies
* if you want to install from git source, you can do pip install -e "git+https://github.com/acsone/account-financial-reporting.git#egg=mis_builder&subdirectory=setup/mis_builder", so there too I think the dot would complicate things

b) I also couldn't find the setup.py file in the  acsone/account-financial-reporting repo. Did i miss something?

They are on the 8.0-with-setup branch. See for instance https://github.com/acsone/account-financial-reporting/tree/8.0-with-setup/setup/ .
There is one setup.py for each addon.

c) How will the "setup" directory be kept up to date? An additional task for the OCA bot?

At first I plan to do it with the OCA bot, yes. The setuptools-odoo-makedefault script (part of setuptools-odoo) does most of the required work already. 
In the future, I hope authors will include the setup.py manually (it's simple enough) and the autogeneration will progressively become unncessary.

Best regards,

-sbi