Contributors mailing list archives

contributors@odoo-community.org

Re: OCA Coding Standards and recommended IDEs

by
ThinkOpen Solutions Portugal, Daniel Reis
- 16/10/2015 12:22:25
Hi Oleg,

The real issue is that we should have command line tool performing the same lint checks done by TravisCI.
This is something that should be done in the OCA/maintainer-quality-tools repo, leveraging the latest configurations there.

It would be nice for it to be able to integrate with popular editors.
That's something to have in mind for the tool's design.

/DR


Às 13:08 de 16/10/2015, Oleg Kuryan escreveu:
<blockquote cite="mid:CAJeyqWJHwcCm5g+55v=zcMjr=ajw_CrM25772TC1HdX-XqVN_Q@mail.gmail.com" type="cite">
Hi Ronald, Leonardo and Yajo,

Thank you for your opinion. I understood your position. My opinion is that such recommendations and recommended tools are helping to have less pain during code review both for developer and reviewer and focus on logic itself instead of styling and readability of code.
Templates/checkers that can be used in different IDEs and Editors saves a lot of time and even help new community members to start faster. From the other side less iterations of travis verification also better to get faster results and get finally feature in.



///

Best Regards,
Oleg Kuryan

Technical Director, XPANSA Group | ERP, BI, E-commerce, Data Mining and DMS consulting
Xpansa has developed first full Odoo Android App called mERP. Download at https://play.google.com/merp
/// site  : xpansa.com
/// mail  : oleg.kuryan@xpansa.com
/// phone : +375293358638
/// skype : kuryan.oleg

On Fri, Oct 16, 2015 at 2:38 PM, Yajo <yajo.sk8@gmail.com> wrote:

2015-10-16 13:23 GMT+02:00 Leonardo Pistone <lpistone@gmail.com>:
I disagree: I don't think we should support / encourage specific IDEs or other tools. These are very personal choices.

Same here. Please don't do it.

As for tools, I agree that we'd need a simple command line wrapper that lints according to the OCA conventions. Then anyone will be able to tell their editor of choice to use it instead of i.e. "flake8".

Everyone is free to use a text editor that has no flake8 support, so adding those checks you say in travis would be wiser IMHO, as it is now with flake8.

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe