1. Mailing Lists
  2. Contributors
  3. Re: Mass commit to prepare branching 9.0

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: Mass commit to prepare branching 9.0

Re: Mass commit to prepare branching 9.0

Avatar

Re: Mass commit to prepare branching 9.0

by
Acsone SA/NV, Stéphane Bidoul
- 09/10/2015 10:52:22
The normalizing of version numbers on the 8.0 branch is done.

Regarding unported I personally prefer to do the git mv on the 8.0 branch so these modules remain visible in the README of the default (9.0) branch. Indeed, I think it is important to give adequate visibility to old unported modules too, until the PSC determines these modules are not needed anymore on a given branch.

The identified cost of this is it requires a rebase of porting PR's in 8.0.

Best regards,

Stéphane Bidoul | @SBidoul
Acsone sa/nv | http://acsone.eu/ | +32 2 888 3120




On Fri, Oct 9, 2015 at 9:38 AM, <Pedro@pad.odoo-community.org> wrote:
Stéphane, go ahead then without normalizing the __unported__ modules, but please take in care Raphaël's comment. Another option is to follow my approach of removing entirely this directory on 9.0.

Regards.

2015-10-09 9:07 GMT+02:00 Raphaël Valyi <rvalyi@akretion.com>:
Hello Stéphane,

 wonder, if you do:
"2 move the content of __unported__ to the root of the repository with "git mv __unported__/* .", also on the 8.0 branch"

-> how will that no break the existing 8.0 PR's ?
Did you think about it? I fear it may even break the ability to rebase and merges these PR's
Or is it okay?

Thanks for your work as usual BTW

On Fri, Oct 9, 2015 at 3:53 AM, <Bidoul@pad.odoo-community.org> wrote:
On Thu, Oct 8, 2015 at 10:38 AM, <Pedro@pad.odoo-community.org> wrote:
Hi, Stephane, maybe we should normalize also version number of __unported__ dir to 7.0.x.y(.z). All modules in __unported__ for 8.0 branch are assured to be 7.0 because a delete was done on 8.0 branch for modules not migrated from 6.1.

Are you 100% sure there is not any old 6.1 modules in 8.0/__unported__? Moreover I find it a bit weird to have unported modules with a greater version number than the last ported version. And I'm lacking time... ;)

So if you don't mind I'll proceed.

By the way, I'm finding here and there some remnant code in unported for modules that are ported (example: hr_expense_sequence in OCA/hr). In such cases I remove the code in 8.0/__unported__ directly without PR.

-sbi


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe




--

_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: http://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: http://odoo-community.org/groups?unsubscribe


Reference