1. Mailing Lists
  2. Contributors
  3. Re: pre-commit changes

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: pre-commit changes

Avatar

Re: pre-commit changes

by
ClosingAp Open Source Integrators Europe, LDA, Daniel Reis
- 09/12/2022 10:32:39
Actually, pre-commit config updates should be on their own commit, so that they don't contaminate the module history.

You may want to also create a separate PR cherry-picking that particular commit, that can be fat tracked by maintainers.
That will avoid the risk of someone else proposing a different commit to update pre-commit config, that will cause you merge conflicts.

Thanks
Daniel

On 06/12/22 13:11, Marco Colombo wrote:
> The idea of the first pre-commit set is to store the automatic changes

Well, I was coming from a place where I'd separate aesthetic changes (automatic or not) vs. functional changes, but thanks for clarifing that.

I'll squash my intermediate commit into the Migration one.

Have a nice day.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


--
DANIEL REIS
MANAGING DIRECTOR

M: +351 919 991 307
E: dreis@OpenSourceIntegrators.com
A: Avenida da República 3000, Estoril Office B, #34

Reference