Contributors mailing list archives

contributors@odoo-community.org

Avatar

Re: Lots of our modules do not handle multi-company correctly with Odoo >= 13

by "Holger Brunn" <mail@hunki-enterprises.nl> - 09/02/2022 14:37:12
Thank you for raising this.


> * gather information about affected modules and versions (so that people

> can quickly check if their instances are affected by this)

could we write the AST version of
grep -RE 'user(_id|).company_id[^s]' --include=*.py
?
(which already finds a lot of problematic cases, but also a lot of false 
positives we could exclude when knowing the code, like in default lambdas)

When we have that we could even flag such lines in PRs to have reviewers/
contributors pay extra attention.


-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com

Reference