Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

Re: The future of oca/bank-payment

by
Tecnativa. S. L., Pedro M. Baeza
- 28/03/2025 08:36:19
Up to the moment, I haven't heard any convincing reason to switch to the new refactoring, except saying the generic words "it does bring value, in terms of compatibility and interoperability with standard Odoo", which is not true, as the compatibility was assured in my previous refactoring generating 100% compatible account.payment records with the account.payment.method.line set on them. On contrary, this new refactoring is deforming more the standard, touching a lot the account.payment.method.line object, as you can see in https://github.com/OCA/bank-payment/pull/1401/files#diff-be0f3f1e5863cde871372af8c252f077a8111278e1fdda3f562415e2d96164ce, trying to convert this object into account.payment.mode. Why doing that if we already have the exact model we need?!! And it's also limiting the selection of the standard res.partner many2one fields. This is not making it more compatible, this is breaking enterprise modules' way or working, as you can't select the payment method line they need!

The effort to educate all our users to the new system is not justified, and there's still more work to do, as the migration scripts are not done.

Finally, this new refactoring has been done over the forked 16.0 version of Alexis, not the clean 17.0 latest version, which is discarding all the contributions made by other OCA contributors meanwhile, which is ugly, and it will also cause solved bugs to appear again.

Due to all of this, we should stick to the existing version, and answering Michael's reply that has just entered while I was redacting this, the current suite has no technical debt. Don't get it wrong.

Regards.

Reference