1. Mailing Lists
  2. Contributors
  3. Re: The future of oca/bank-payment

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Re: The future of oca/bank-payment

Re: The future of oca/bank-payment

Avatar

Re: The future of oca/bank-payment

by
DIXMIT Consulting SLU, Enric Tobella Alomar
- 26/03/2025 19:30:23
Dear Alexis,

I think that Pedro exposed a perfect example of what we might loose. We are trying to enforce the logic of the system to fit in Odoo's standard, but sometimes it doesn't. I think this is one of this cases. Maybe on the future Odoo makes changes so we don't have this discussion anymore, but it is not the moment right now.

Actually, some of my customers are using the exact example that Pedro provided.

Anyways, this is just a complain of one of the changes, for all the others, I would prefer to see a more granular commit history in order to evaluate it. Also, some of the changes have conflicts with changes applied to the module by other contributors that you forget to add. Right now we are providing a massive change with 4000 additions and 8000 deletions. Also, there we can find conflicts.

Just to finish, the migrations that you made come from your main branch. I know that you use only some of the versions, but the right approach is to use 17 to get the changes of the latest version (also it is easier to detect changes on names and so on to create the migration scripts). It might be harder for you, but this is how it should be done.

Kind regards,

El mié, 26 mar 2025 a las 18:58, Pedro M. Baeza (<notifications@odoo-community.org>) escribió:
>About the work method to bring these evolutions, I also totally agree that doing changes in small steps is preferable, but the problem is when you want to do large scale improvements, it is impossible when a version is released, as you inevitably need to break compatibility for someone, even in small ways, so improvements within an Odoo series we are quickly frozen. So the best moment is when doing a major upgrade. That is why Alexis prepared the work on 16.0 to show what he was aiming at, and now is a good moment to land his work in 18.0.

That's not true. He continously refuses to split the changes, and has a chaotic commit history, with no explanations, data model changes, etc, all mixed, as it happened in v9.

> About the Payment Mode, In my view it does bring value, in terms of compatibility and interoperability with standard Odoo, as well as ergonomics

There's no such compatibility problems, and the interoperability is already assured on the generated account.payment. This is not something new of this version.

> avoiding two fields and models with almost identical meaning.

That's the problem: they are far from being identical in meaning. The payment mode is far more advanced than the payment method line. It allows you to have a text associated that it's shown in the invoices. It allows you to dynamically have bank account numbers displayed in the invoice (both customers and your own bank accounts). It allows you to aggregate as you prefer payment methods with bank accounts, etc.

Imagine this case: you have a generic payment mode called "SEPA DD" with 5 bank accounts (journals) linked, but other payment modes "SEPA DD Bank 1", "SEPA DD Bank 2", etc, and for certain invoices, you change the payment mode for fixing that bank, but by default, the generic one is used and the bank is not important. You won't be able to do this with your new approach.

> About the migration effort, yes, there is some

There's a lot of effort, and confused users about the why of this change. There's no advantages in this change. And you are not saving tons of code as the previous refactoring did. Just 2 m2o fields...

I stay in my position of keeping current modules, which are not old, are stable and with no need of changing that.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--
Enric Tobella Alomar
CEO & Founder

Reference