1. Mailing Lists
  2. Contributors
  3. Re: Big number changed automatically on float fields

Contributors mailing list archives

contributors@odoo-community.org

Browse archives

RE: Big number changed automatically on float fields

Re: Big number changed automatically on float fields

Avatar

Re: Big number changed automatically on float fields

by
Ing. Rolando Pérez Rebollo
- 23/10/2024 16:36:53

> I'm interested in the business context of this problem. What kind of accounting are you doing where numbers have 19 digits?

It's a country with a very high inflation but the company operations really runs in USD so when converting from USD to local currency there are these kind of large numbers.

> A value with the last Nth digits changed.

For 1513372483569320000 is always the last five digits, the number stays the same till 15133724835693. My guess is due to the use of float for scientific notation the rest of the number gets messed up for some sort of global digit precision setting.

The columns in postgres that stores the values for credit and debit fields are of type numeric but without precision and scale settings. For me the responsible for the issue is python.


On 10/23/24 10:12, Janik von Rotz wrote:

Hi Rolando

I'm interested in the business context of this problem. What kind of accounting are you doing where numbers have 19 digits?

Your questions reminds me of the first Odoo Partner Days. Somebody asked something similar in the context of fuel prices. Fabien opened an interactive python shell and did something like:

>>> import math
>>> math.pow(2, 64)
1.8446744073709552e+19

The question was dismissed and we went on to the next question.

> A value with the last Nth digits changed.

What exactly changes? Can you compare the number entered and retrieved?

Cheers, Janik

On 10/23/24 15:32, Rolando Pérez Rebollo wrote:

Hello, when trying to input very large numbers (with no decimals, 19 digits in my specific case) in credit or debit fields from journal items these numbers are changed on saving automatically with no explanation. The issue is easily reproducible in runbot Odoo 16 CE. I think a similar issue has been reported on github (https://github.com/odoo/odoo/issues/82597).

Steps to reproduce (from a user with full accounting features enabled), demo db from runbot.com 16.0 CE:

- Go to Invoicing/Accounting/Journal Entries

- Create a new one

- In Journal Items add a new line like this:

 

- When saved we get:

A value with the last Nth digits changed.

I was able to debug in a local environment and my observations are:

  • Is not a problem from UI: emulating the creation of journal items from code gets the same results.
  • Is not a problem of visualization: wrong values are persisted into database.
  • At ORM level the large numbers are represented in python scientific notation, in this case 1.51337248356932e+18
    • From there python float "features" begin to work and the float part of the scientific notation gets transformed due to the way python stores float numbers.
  • If my tests are not wrong every single float field in Odoo is hit by this.

I think is rare nobody has notice this before. Maybe I'm ignoring some very basic fact about currency settings in Odoo that's why I'm reaching U for help or any creative idea.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

-- 
We are hiring: https://www.mint-system.ch/jobs
Send application to: jobs@mint-system.ch

CTO Mint System GmbH 
Tel: +41 44 244 7222

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference