Contributors mailing list archives

contributors@odoo-community.org

Avatar

Re: 13.0 Migration instructions

by
Camptocamp SA, Yannick Payot
- 04/10/2019 14:27:02
To keep in mind, we are talking only about administrative commits that were created due to the previous commit.

We should only squash commits if it was clearly identified after a "real" commit and in clear relation with that commit by the ocabot or a maintainer.


Because for translation commits when migrating to 12.0 we squashed all in one for updates from Transifex.
In this case it's not relevant to squash them to the previous commit.
It could add big noise to a simple fix commit of 2 lines that doesn't affect the translation terms.

Regards,
Yannick Vaucher
Business Solutions Architect

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 30
Office: +41 21 619 10 10


On Mon, 30 Sep 2019 at 15:07, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
The idea is to merge them with the first "real commit".

Imagine this commit history (from more recent to older):

[UPD] README.rst
Update translation files
[MIG] xxxx: Migration to version 12.0

Squashing all of them with the migration commit doesn't lose the commit history meaning.

Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Reference