Contributors mailing list archives

contributors@odoo-community.org

Avatar

Re: How to skip pylint check

by
Lorenzo Battistini
- 11/07/2019 10:48:22

On Thu, 11 Jul 2019 at 12:22, Andrea Stirpe <a.stirpe@onestein.nl> wrote:
Prego!

This one is a red error for sure:

l10n_it_withholding_tax/models/withholding_tax.py:128: [E8103(sql-injection), WithholdingTaxRate._check_date] SQL injection risk. Use parameters if you can. - More info https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#no-sql-injection

I do not see a second one, so I'm suspecting that the pylint error counter is wrong.






From: "Lorenzo Battistini" <elbaddy@gmail.com>
To: "Odoo Community Association, (OCA) Contributors" <contributors@odoo-community.org>
Sent: Thursday, July 11, 2019 12:07:42 PM
Subject: Re: How to skip pylint check

Grazie mille!

Could you help me to understand why this build
is failing?

It says
pylint expected errors 0, found 2!
Which ones?

Thanks


On Thu, 11 Jul 2019 at 09:42, Andrea Stirpe <a.stirpe@onestein.nl> wrote:
Try with:

self._cr.commit()  # pylint: disable=invalid-commit





From: "Lorenzo Battistini" <elbaddy@gmail.com>
To: "Contributors" <contributors@odoo-community.org>
Sent: Thursday, July 11, 2019 9:27:07 AM
Subject: How to skip pylint check

Hi all,

sometimes we need to avoid some lines of code being checked by pylint.
Example: we use self._cr.commit() on purpose and we want to avoid E8102 error.

I tried with
self._cr.commit()  # noqa
but it seems it is still failing:

So, how can I skip lint checks to make travis green?

Thanks!

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



--

Reference