Point of Sale mailing list archives

pos@odoo-community.org

Avatar

Re: [OCA/pos] Automatic Stale PR/Issues workflow (#691)

by "Iván Todorovich" <notifications@github.com> - 27/07/2021 13:35:11

But in the meantime, I think that 120 days is not so much ! Maybe it requires to organize some review session, something like 4 time a year. What do you think ?

Let me first do a quick summary of how it works, in case people don't know.

The policy is in fact 120+30. This means: if there's no activity in 120 days the action will label it as stale, and post a message.

If it remains without activity for 30 more days, it closes it. Please note that a simple comment from anyone counts as activity, so people interested in the PR to remain open have plenty of time to do so. Also the PSC members can use a label "no stale" to keep it open forever.

What we'd expect from this is to have an automated system that forces and remainds us to qualify PRs.. and that closes them automatically if there's no public interest in them anymore

I recommend you join the discussion in the other thread to talk and brainstorm about possible policies ☺️ your experience as maintainer is appreciated

Technical question : your PR is against 14.0. When we'll migrate to 15.0 do you have to move the github action settings on V15. keep the V14 code ? both code will be executed ?

For scheduled actions like this one, only the workflow in the repository's default branch is executed. So yes we need to copy onto the new branches as we create them (although copier takes care of it)


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Reference