Contributors mailing list archives

contributors@odoo-community.org

Browse archives

Avatar

Re: Server-tools split environment related modules

by
LasLabs, Dave Lasley
- 29/11/2017 23:20:13
+1 I think this makes sense. There are a lot of different contexts that could require a different handling of object X in environment Y, none of which have to do with auth.

— Dave Lasley

On Nov 29, 2017, at 10:47 AM, Yannick Vaucher <yannick.vaucher@camptocamp.com> wrote:

server_environment modules and keychain are quite different

The objective of server_environment is to have config files that setup multiple parts of odoo.
It is not based on an account basis.

For instance:

* you can change existing models to change behavior of some fields depending on env
* you can have different value of ir.config.parameters depending on the env.
* you can create your module to set a specific field as non editable and only set by config file also depending on env
* you can have a default config and make specifics only in some envs

For me it completely make sense to extract them together in an other repository. It's more maintainable and don't force people not using pip install to download them.
Why couldn't this also be extracted as we have 5 modules on the same topic ? server-brand has the same number of modules.


Cheers,


Yannick Vaucher
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 30
Office: +41 21 619 10 10

On 29 November 2017 at 18:32, David Beal <david.beal@akretion.com> wrote:
Ok,

I don't want to force anyone to use keychain ;-), that's not the purpose
just say keychain main features (from readme) are :
  • All the crendentials are stored in one place: easier to manage and to audit.
  • Multi-account made possible without effort.
  • Store additionnal data for each account.
  • Validation rules for additional data.
  • Have different account for different environments (prod / test / env / etc).

Long life to server_environnement ;-)

but why in another repo if it's the topic is really near ?

I want block nothing, but we switch from 1 excess to another : too many modules by repos to too many repos with no so differentiate features.

but not a real problem for me.

my 2 cents




Bonne journée


David BEAL - Akretion
Odoo Development / Integration

2017-11-29 15:02 GMT+01:00 Simone Orsi <simahawk@gmail.com>:
+1 for splitting

@David: `keychain` is another story, is for storing sensible data. 

Also, `server_environment` family already has a lot of children well known and used by many OCA members ;)

Cheers,

On Wed, Nov 29, 2017 at 2:32 PM, David Beal <david.beal@akretion.com> wrote:
Hi Yannick,

Please look at https://github.com/OCA/server-auth

keychain with nearly the same scope than server_envir.... is there (migrated by an odoo developper mart-e)


Bonne journée


David BEAL - Akretion
Odoo Development / Integration

2017-11-29 14:17 GMT+01:00 Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com>:
Sorry, I didn't cross-compare the links, as mine was the GitHub issue.

Well, I'm not sure if this is too much split and we are going to have a lot of repositories without too much modules. We have never used that modules as we have a Docker infrastructure that doesn't need them, and I have never like the structure with the need of that extra module (server_environment_files), but if you still continue maintaining them, then decide the best strategy.

Regards.

2017-11-29 14:02 GMT+01:00 Yannick Vaucher <yannick.vaucher@camptocamp.com>:
Pedro, I was refering to that split in my message, please see that I linked the same spreadsheet.

Yannick Vaucher
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne

On 29 November 2017 at 13:47, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
Hi, Yannick, there's already a split in progress. See https://github.com/OCA/server-tools/issues/1008. Look if it's enough.

Regards.

2017-11-29 13:32 GMT+01:00 Yannick Vaucher <yannick.vaucher@camptocamp.com>:
Hello,

I'm just looking for other opinions about having specific environment ('dev', 'test', 'qa', 'prod', ...)
modules in it's own project repository.

Here are the modules:

mail_environment
server_env_base_external_referentials
server_environment
server_environment_files_sample
server_environment_ir_config_parameter

What about creating a OCA/server-env project ?

(I propose the short env as it is clear what it means and we already have server-ux which didn't bother anyone)

Here are some PR which were already made for those modules but not merged yet:


It would be the right time to forward them to a new project repository.

Why should we do it ?
- We wanted to split the repo which dragged to many addons as being too generic.
- Environment related addons might grow
- it's a topic on itself

Why we shouldn't?
- we don't want too many repositories
- server-environment is a well know module and has always been in server-tools

(not sure there is a dedicated mailing list for server-* topic)

Yannick Vaucher
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne

_______________________________________________



_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe



Reference